-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte v5 RC: TreeView component is non-function #2639
Comments
Regrettably, the In Svelte 4, components are represented as classes, which are utilized within the tree-view to allocate events to its children. see: https://svelte-5-preview.vercel.app/docs/breaking-changes#components-are-no-longer-classes |
Hi @Mahmoud-zino , are there any plan to add tree views components ( |
@linkfang current plans are as follows:
It's not ideal, but this there's a lot of changes happening, and we're not going to implement a beta feature within our stable release. |
Sounds good! Thanks for the detailed info! |
Current Behavior
This component works as expected in Svelte v4. However, while testing the Svelte v5 RC, there are a number of errors present when using this component. See the screenshot below:
a11y warning:
Expected Behavior
While we won't be utilizing Svelte v5 features in Skeleton until our v3 release, we do expect users to migrate to Svelte v5 prior to migrating to Skeleton v3. This means there will be a period of time while they are running Skeleton v2 + Svelte v5. As such, we should try to resolve these errors as they are breaking issues.
Steps To Reproduce
You can temporarily switch to Svelte v5 RC to test and develop your changes using:
The doc site should remain fully functional during this. Just make sure to revert these changes before we merge these changes in to the
dev
branch.Link to Reproduction / Stackblitz
No response
More Information
It's of the upmost importance that we do not merge the Svelte v5 RC dependency change into
dev
branch, so take care to add a big markdown note in the PR message please!ETA for this change is before the Svelte v5 stable release, but the sooner the better for early adopters!
The text was updated successfully, but these errors were encountered: