Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github actions is letting failures pass #98

Closed
skx opened this issue Nov 21, 2022 · 1 comment · Fixed by #102
Closed

Github actions is letting failures pass #98

skx opened this issue Nov 21, 2022 · 1 comment · Fixed by #102
Assignees
@skx

Comments

@skx
Copy link
Owner

skx commented Nov 21, 2022

Consider this recent run:

That should have failed, but it passed.
@skx skx self-assigned this Nov 21, 2022
@skx
Copy link
Owner Author

skx commented Nov 21, 2022

New issue currently present can be used to test:

  • eval/eval.go:420:11: if block ends with a return statement, so drop this else and outdent its block

@skx skx mentioned this issue Nov 21, 2022
Merged
@skx skx closed this as completed in #102 Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skx skx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure CI failures will fail our pipeline. skx/yal
1 participant
@skx