-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Psych 5 #437
Comments
Hi @dorianmariefr! I don't believe this is an issue with either Skylight nor Psych 5 (your backtrace appears to be pointing to the vendored Psych for ruby 3.1, which is v4). Ruby should load psych from a gem if it is installed; if it's only in your Gemfile it may not have been installed yet when Skylight's extconf.rb ran. Try a |
@zvkemp The build and the tests work fine before upgrading to psych 5. I have libyaml-dev installed (it was generating a I set up a debugging session on GitHub Actions and was able to successfully install psych 5
I was also able to successfully install skylight with But when I installed ruby with rvm, and I do a
I tried removing psych from our Gemfile, removing the |
The issue must be related to bundler not running with your If you have a Dockerfile or another way to reproduce the error, I would be happy to take a look, but since this isn't really a Skylight issue (we're only calling public methods on built-in Ruby classes), there's nothing for us to fix here. |
We didn't figure it out, we solved this by removing psych from our explicit dependencies as it's not needed by our app |
So this exact error happens in my app (Rails 7.0, Skylight 5.3). I'm using the I am installing the |
IMO this ticket on ruby core might shad some light on the root cause. If you have both Psych 4 and 5 this issues appears. After reading this ticket I have removed Psych 5, now bundle is not giving any errors and Skylight is installed correctly. |
Same issue here. Gemfile.lock
While i personally don't have psych in my Gemfile, there's
|
I believe you are encountering this Ruby bug: https://ml.ruby-lang.org/mailman3/hyperkitty/list/[email protected]/message/ZYU7X5A336FDS3BRM37NL47VWJXE3GGP/ It seems you can remove Psych 5 if it is not explicitly required by your Gemfile.lock. On our side, I will investigate bundling a specific YAML parser (or using a different format during extconf) to avoid the issue entirely. |
I had to manually remove then then migrating, for some reason i had to completely clean the bundle cache with not sure if there's another way, but at least i could continue, and use skylight now :) |
It seems this issue was fixed in Rubygems 3.4.9 (https://github.com/rubygems/rubygems/blob/master/CHANGELOG.md#349--2023-03-20). |
This issue is now bypassed in v6.0.2 — we no longer require yaml during extconf. |
I'm getting this output when upgrading psych from 4 to 5:
The text was updated successfully, but these errors were encountered: