Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop unit tests from modifying config files #577

Closed
blonienc opened this issue Jun 20, 2024 · 0 comments · Fixed by #580
Closed

Stop unit tests from modifying config files #577

blonienc opened this issue Jun 20, 2024 · 0 comments · Fixed by #580
Assignees
Labels
bug Something isn't working python Pull requests that update Python code

Comments

@blonienc
Copy link

blonienc commented Jun 20, 2024

Description: There's currently a bug where running unit tests (poetry run poe test) will result in .secureli.yaml being modified to include a "scan_patterns" property which is used for unit testing the custom regex scanner feature.

The unit tests need to be updated so that .secureli.yaml isn't updated at all during unit testing. We should instead be mocking the .secureli.yaml file in the tests.

AC: running unit tests locally does not result in any config files being modified

@blonienc blonienc converted this from a draft issue Jun 20, 2024
@blonienc blonienc added bug Something isn't working python Pull requests that update Python code labels Jun 20, 2024
@blonienc blonienc changed the title Config Bug Config Overwrite Bug Jun 20, 2024
@ian-bowden-slalom ian-bowden-slalom changed the title Config Overwrite Bug Stop unit tests from modifying config files Jun 21, 2024
@ian-bowden-slalom ian-bowden-slalom moved this from Todo to In Progress in seCureLI Jun 27, 2024
@ian-bowden-slalom ian-bowden-slalom self-assigned this Jun 27, 2024
@ian-bowden-slalom ian-bowden-slalom linked a pull request Jun 27, 2024 that will close this issue
8 tasks
@ian-bowden-slalom ian-bowden-slalom moved this from In Progress to PR Review in seCureLI Jun 27, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in seCureLI Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants