fix: 修复缩略图路径前缀重复的问题 #452
Closed
fix: 修复缩略图路径前缀重复的问题 #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我觉得这个修复方案不好，应该读取当前所用的 disk 然后将缩略图使用磁盘系统写入，否则在 docker 容器下会出现写入容器问题，还有可能出现写错位置问题。
Seven Du <[email protected]<mailto:[email protected]>>
在 2018年11月28日，20:06，Will <[email protected]<mailto:[email protected]>> 写道：
目前缩略图路径有问题， 假设 文件文件存储路径为 /www/site/storage/app
实际缩略图保存路径会是： /www/site/storage/app/www/site/storage/app/YYYY/MM/DD/xxx/xxx.jpeg
并且导致windows下无法创建目录和生成缩略图，因此无法访问图片
…________________________________
You can view, comment on, or merge this pull request online at:
#452
Commit Summary
* fix: 修复缩略图路径前缀重复的问题
File Changes
* M app/FileStorage/Filesystems/LocalFilesystem.php<https://github.com/slimkit/plus/pull/452/files#diff-0> (2)
Patch Links:
* https://github.com/slimkit/plus/pull/452.patch
* https://github.com/slimkit/plus/pull/452.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#452>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFTplbxtXek_0-rMMn5-SwvR04x4QdePks5uznwqgaJpZM4Y3dvs>.
|
|
明天我编辑一下这个 PR 使用文件系统写入缩略图， Windows 确实是当时没有考虑到的
Seven Du <[email protected]<mailto:[email protected]>>
在 2018年11月28日，20:06，Will <[email protected]<mailto:[email protected]>> 写道：
目前缩略图路径有问题， 假设 文件文件存储路径为 /www/site/storage/app
实际缩略图保存路径会是： /www/site/storage/app/www/site/storage/app/YYYY/MM/DD/xxx/xxx.jpeg
并且导致windows下无法创建目录和生成缩略图，因此无法访问图片
…________________________________
You can view, comment on, or merge this pull request online at:
#452
Commit Summary
* fix: 修复缩略图路径前缀重复的问题
File Changes
* M app/FileStorage/Filesystems/LocalFilesystem.php<https://github.com/slimkit/plus/pull/452/files#diff-0> (2)
Patch Links:
* https://github.com/slimkit/plus/pull/452.patch
* https://github.com/slimkit/plus/pull/452.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#452>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFTplbxtXek_0-rMMn5-SwvR04x4QdePks5uznwqgaJpZM4Y3dvs>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前缩略图路径有问题， 假设 文件文件存储路径为 /www/site/storage/app
实际缩略图保存路径会是： /www/site/storage/app/www/site/storage/app/YYYY/MM/DD/xxx/xxx.jpeg
并且导致windows下无法创建目录和生成缩略图，因此无法访问图片