You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Needs documentation and tests before opening a PR to upstream.
The qsh commands are meant to be "quiet" versions while the sh ones are verbose. I would change those around. sh should be quiet. qsh might be confused for a shell called "qsh", so they should be renamed to sh_verbose or just add a verbose flag to the sh commands.
The four blocks of code in src/builtin.c are very repetitive and need to be reduced. See:
See the
sh-support
branch for code from userhaochenx
that adds support for shell I/O. Also see: https://stackoverflow.com/a/53273617/543738Needs documentation and tests before opening a PR to upstream.
The
qsh
commands are meant to be "quiet" versions while thesh
ones are verbose. I would change those around.sh
should be quiet.qsh
might be confused for a shell called "qsh", so they should be renamed tosh_verbose
or just add a verbose flag to thesh
commands.The four blocks of code in
src/builtin.c
are very repetitive and need to be reduced. See:jq/src/builtin.c
Lines 1565 to 1603 in 21da66b
Also see upstream issues stedolan#147 and stedolan#1101.
The text was updated successfully, but these errors were encountered: