Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve marge comment on push failure #234

Open
bagage opened this issue Oct 14, 2019 · 1 comment
Open

Improve marge comment on push failure #234

bagage opened this issue Oct 14, 2019 · 1 comment

Comments

@bagage
Copy link

bagage commented Oct 14, 2019

When marge has not enough write access to a repository, she fails and had a comment I couldn't merge this branch: Failed to push rebased changes, check my logs!.

In the logs, one can see:

marge_1 | 2019-10-14 11:51:52,294 INFO Running git -C /tmpd22x27wg/tmpo0jqkj2e push --force source feat/new-option-button:feat/new-option-button
marge_1 | 2019-10-14 11:51:52,593 WARNING git returned 128
marge_1 | 2019-10-14 11:51:52,593 WARNING stdout: b''
marge_1 | 2019-10-14 11:51:52,593 WARNING stderr: b'> GitLab: You are not allowed to push code to this project.\nfatal: Could not read from remote repository.\n\nPlease make sure you have the correct access rights\nand the repository exists.\n'

Could the message be improved to hint about permission issue?

@alatiera
Copy link

alatiera commented Nov 19, 2019

I wonder if this could also be turned into a check for the 'Allow maintainers to push to this MR' checkbox feature, since its off by default and its required in order to rebase an MR. Would it make sense? and where would I need to look if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants