Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Branch: Member filter extension url is incorrect #87

Open
gotdan opened this issue Jan 15, 2025 · 4 comments
Open

Dev Branch: Member filter extension url is incorrect #87

gotdan opened this issue Jan 15, 2025 · 4 comments
Assignees

Comments

@gotdan
Copy link
Contributor

gotdan commented Jan 15, 2025

It should be member-filter instead of memberFilter. This is wrong in the IG docs and examples too which I'll fix.

@gotdan gotdan assigned gotdan and vlad-ignatov and unassigned gotdan Jan 15, 2025
@vlad-ignatov
Copy link
Contributor

Not sure what you mean. I am currently only testing if it ends with "memberFilter". Is that going to change?
https://github.com/smart-on-fhir/bulk-data-server/blob/dev/fhir/group.ts#L189

@gotdan
Copy link
Contributor Author

gotdan commented Jan 17, 2025

Yup, it should end in member-filter like https://build.fhir.org/ig/HL7/bulk-data/branches/argo24/group.html#example

@vlad-ignatov
Copy link
Contributor

OK. Is that like a constant URL that I match exactly, or should I continue to look for the last segment?

@gotdan
Copy link
Contributor Author

gotdan commented Jan 17, 2025

The extensions may move to the extension registry which would change their canonical url, so continuing to look at just the last segment until the final IG is published makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants