Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.10] Add validator to check for traits applied to prelude shapes #278

Closed
mtdowling opened this issue Feb 19, 2020 · 0 comments
Closed

[0.10] Add validator to check for traits applied to prelude shapes #278

mtdowling opened this issue Feb 19, 2020 · 0 comments
Assignees
@srchase
Labels
feature-request A feature should be added or improved. GA

Comments

@mtdowling
Copy link
Member

We should emit an ERROR for when traits are applied to prelude shapes outside of the prelude. Applying traits to prelude traits could have wide and unintended consequences when defining and merging models.
@mtdowling mtdowling added the feature-request A feature should be added or improved. label Feb 19, 2020
@mtdowling mtdowling changed the title Add validator to check for traits applied to prelude shapes [0.10] Add validator to check for traits applied to prelude shapes Feb 20, 2020
@mtdowling mtdowling added the GA label Feb 26, 2020
@kstich kstich mentioned this issue Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srchase srchase

Labels
feature-request A feature should be added or improved. GA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtdowling @srchase