Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smithy-build.json without required field does not fail as expected #448

Closed
kggilmer opened this issue May 27, 2020 · 2 comments
Closed

smithy-build.json without required field does not fail as expected #448

kggilmer opened this issue May 27, 2020 · 2 comments
Labels
bug This issue is a bug. documentation This is a problem with documentation.

Comments

@kggilmer
Copy link
Contributor

kggilmer commented May 27, 2020 •
edited
Loading

Steps to reproduce:

  1. Notice that output is defined as a required field in smithy-build.json in https://awslabs.github.io/smithy/guides/building-models/build-config.html
  2. Follow README example which does not define output.

Expected results: The lack of required field should produce an error
Actual results: Provided a model, the build completes successfully
@mtdowling
Copy link
Member

Ah, this is erroneous documentation -- output isn't required any longer. We'll fix.

@mtdowling mtdowling added bug This issue is a bug. documentation This is a problem with documentation. labels May 27, 2020
@JordonPhillips JordonPhillips mentioned this issue May 27, 2020
Merged
@JordonPhillips
Copy link
Contributor

Fixed with #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. documentation This is a problem with documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtdowling @JordonPhillips @kggilmer