-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled mention-bot #745
Comments
My observation: in #747 mention-bot mentioned, dpino, alex and me. Imho that's a 2/3 failure rate. I think dpino wrote the code in question, so one might argue he would like to know about this, and I would probably have mentioned him anyways. Alex and me on the other hand... not so much. E.g. I think mention-bot is overzealous, but maybe I am just mad because the machines are taking away my job. ;-) |
To me it's not a failure to mention someone who's not a domain expert in the code at hand, dunno. I think mentioning you @eugeneia is a success in some way, as you actually maintain an integration branch, and it's conceivable that alex might also have a good comment as an experience snabber. Your mileage evidently varies :) |
OK I now side with @eugeneia :) At the very least if the original issue or PR @-mentions a person, having mention-bot chime in is not necessary and a bit annoying :) |
I enabled mention-bot as an experiment. The idea is that when a Pull Request is opened this bot will automatically look at the diff and post a comment that @mentions people who are likely to know about the code being changed.
This is meant as a simple "heads up" notification to make relevant code changes more visible to people. There is no obligation to respond when mention-bot tags you.
If you have thoughts on the matter then please leave a comment below :).
The text was updated successfully, but these errors were encountered: