refactor: migrate voting power to vue query #1220
Open
+238
−330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR refactors the voting power logic by migrating the voting power composable/store code to use vue-query, ensuring that errors from fetching voting power for both proposals and spaces are handled independently. Key changes include:
- Replacing the legacy voting power store/composable with useQuery–based implementations in votingPower.ts.
- Updating the Space/Proposals and Proposal views to use the new vue-query hooks.
- Removing the old voting power store and composable files while updating related components and modals.
Reviewed Changes
| File | Description |
|---|---|
| apps/ui/src/queries/votingPower.ts | Introduces vue-query-based fetching of voting power with new query keys. |
| apps/ui/src/views/Space/Proposals.vue | Updates to use the new useSpaceVotingPowerQuery, removing legacy calls. |
| apps/ui/src/views/Proposal.vue | Uses the new useProposalVotingPowerQuery, refactoring error and loading states. |
| apps/ui/src/stores/votingPowers.ts | Entire file removed as part of the migration. |
| apps/ui/src/composables/useVotingPower.ts | Entire file removed as part of the migration. |
| apps/ui/src/components/Modal/VotingPower.vue | Adjusted imports and event names to match new voting power query usage. |
| apps/ui/src/components/Modal/Vote.vue | Updated to utilize the new proposal voting power query. |
| apps/ui/src/components/IndicatorVotingPower.vue | Refactored to use new props and imports from the updated voting power query. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
There was a problem hiding this comment.
PR Overview
This PR refactors voting power logic by migrating from the previous composable/store implementation to use vue-query. Key changes include:
- Introducing new queries in apps/ui/src/queries/votingPower.ts for retrieving voting power.
- Updating components, views, and helper imports to use the new queries.
- Removing the obsolete voting power store and composable files.
Reviewed Changes
| File | Description |
|---|---|
| apps/ui/src/queries/votingPower.ts | Introduces voting power queries and related helper functions |
| apps/ui/src/helpers/utils.ts | Updates import source of VotingPowerItem to the new queries |
| apps/ui/src/views/Space/Proposals.vue | Replaces the old voting power composable with the new query hooks |
| apps/ui/src/views/Proposal.vue | Replaces voting power fetching and handling with new query hooks |
| apps/ui/src/stores/votingPowers.ts | Removes the obsolete voting power store |
| apps/ui/src/composables/useVotingPower.ts | Removes the obsolete voting power composable |
| apps/ui/src/components/ProposalsListItem.vue | Minor adjustment to conditionally render the vote modal |
| apps/ui/src/components/Modal/VotingPower.vue | Updates props and event names to align with the new query implementation |
| apps/ui/src/components/Modal/Vote.vue | Updates voting power handling to use the new query, including proper state |
| apps/ui/src/components/MessageVotingPower.vue | Updates import source for VotingPowerItem to the new queries |
| apps/ui/src/components/IndicatorVotingPower.vue | Updates props, import, and event to use the new voting power query setup |
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #939
Toward https://github.com/snapshot-labs/workflow/issues/410
This PR completes the refactoring process on the voting/proposing power composable, by migrating the remaining voting power composable/store to vue-query
This also fix an issue where any errors on either the proposing power or voting power would fail the entire fetching in the single multi-use composable.
How to test