Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit the proposalId in the ProposalCreated event #616

Closed
pscott opened this issue May 30, 2024 · 0 comments · Fixed by #619
Closed

Emit the proposalId in the ProposalCreated event #616

pscott opened this issue May 30, 2024 · 0 comments · Fixed by #619
Assignees
@pscott

Comments

@pscott
Copy link
Contributor

pscott commented May 30, 2024

To do that we need to first pass in the proposalId in the l1 relayer execution strategy.
Also, we might as well remove the salt from the MetaTransaction type as they are no longer needed for uniqueness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pscott pscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: add proposalId to proposalCreated event snapshot-labs/sx-starknet
1 participant
@pscott