[BUG] Moving items out of the GUI

[Specimen197]

Is there an existing issue for this?

• I have searched the existing issues

Type of bug

Exploit

Environment

- Server Version: Paper 1.20.4
- Shop Version: Shop v1.8.4.7

Server startup log

https://paste.gg/p/anonymous/80ce345362c44a9e9c62c6f8552c8b9b

Shop config files

https://paste.gg/p/anonymous/19b81e6845824aebbd63a84951e2415d

Error log (if applicable)

No response

Bug description

The issue is players can remove items from the /shop gui. This includes navigation buttons, and items that are listed for other players shops. For example, Player B is selling a diamond sword - another user is able to sometimes remove this sword from the GUI without paying for the item and use it as if they crafted it.

Steps to reproduce

• Open /shop
• Click on any icon available from any category
• Hold left click and drag the item out of the menu

Expected behaviour

• Player opens /shop
• Click the category they want to visit
• Click the relevant item they wish to teleport to, or simply browse

Actual behaviour

• Intermittently, when clicking on a button a player is able to remove an item from the /shop gui and keep said item.

Other information

This is an intermittent issue that was reported in the last release of Shop.

[OstlerDev]

I am unable to replicate this bug in Paper after much testing with and without lag and even on very low resource servers, and it should have been fixed as of 2 years ago (as of [1.8.4.2]). Please verify that you update to the most recent version. I am going to close this ticket for now, but if you are able to replicate the issue please let me know and reopen this ticket/log a new bug.

[OstlerDev]

Reopening so that people can add more details on steps to replicate.

[OstlerDev]

Please add reproduction steps if you can get this issue to occur, I have tried for multiple days several hours each day to reproduce the issue and have not been able to get it working. I will continue looking into this, but additional steps for how to reproduce the bug would be super helpful 😄