Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addToBuffer doesn't always hit flushBuffer #20

Closed
jonalmeida opened this issue Sep 7, 2014 · 0 comments
Closed

Fix addToBuffer doesn't always hit flushBuffer #20

jonalmeida opened this issue Sep 7, 2014 · 0 comments
Assignees
@jonalmeida
Labels
status:completed Completed - but might not be released yet. type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone
Version 0.1.1

Comments

@jonalmeida
Copy link
Contributor

We call on super.flushBuffer() which is means we do get affected by snowplow/snowplow-java-tracker#79. There isn't any need to call on super, so we can remove this from the android-tracker.
@jonalmeida jonalmeida added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Sep 7, 2014
@jonalmeida jonalmeida self-assigned this Sep 7, 2014
@jonalmeida jonalmeida added this to the Version 0.1.1 milestone Sep 7, 2014
@jonalmeida jonalmeida added the status:completed Completed - but might not be released yet. label Sep 7, 2014
@alexanderdean alexanderdean changed the title addToBuffer doesn't always hit flushBuffer Fix addToBuffer doesn't always hit flushBuffer Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonalmeida jonalmeida

Labels
status:completed Completed - but might not be released yet. type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
Version 0.1.1
Development

No branches or pull requests
1 participant
@jonalmeida