Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sending a flushBuffer twice stops the database from removing pending flags on events #24

Closed
jonalmeida opened this issue Sep 11, 2014 · 0 comments
Closed

Fix sending a flushBuffer twice stops the database from removing pending flags on events #24

jonalmeida opened this issue Sep 11, 2014 · 0 comments
Assignees
@jonalmeida
Labels
status:completed Completed - but might not be released yet. type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone
Version 0.1.1

Comments

@jonalmeida
Copy link
Contributor

In flushBuffer we re-initialize the indexArray that holds the events with the pending flag set. So pending events are eventually forgotten.

The fix is to make a copy of the indexArray when right before we hit the AsyncTask and use that copy to call EventStore.removeEvent.
@jonalmeida jonalmeida added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Sep 11, 2014
@jonalmeida jonalmeida self-assigned this Sep 11, 2014
@jonalmeida jonalmeida added this to the Version 0.1.1 milestone Sep 11, 2014
@jonalmeida jonalmeida added the status:completed Completed - but might not be released yet. label Sep 11, 2014
@alexanderdean alexanderdean changed the title Sending a flushBuffer twice stops the database from removing pending flags on events Fix sending a flushBuffer twice stops the database from removing pending flags on events Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonalmeida jonalmeida

Labels
status:completed Completed - but might not be released yet. type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
Version 0.1.1
Development

No branches or pull requests
1 participant
@jonalmeida