feat: support empty target framework

snyk · Jan 4, 2019 · 4618bdf · 4618bdf
1 parent 9d4ece5
commit 4618bdf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/parsers/index.ts b/lib/parsers/index.ts
@@ -296,6 +296,9 @@ export function getTargetFrameworksFromProjectConfig(manifestFile) {
   const packages = _.get(manifestFile, 'packages.package', []);
 
   packages.forEach((item) => {
+    if (!item.$.targetFramework) {
+      return;
+    }
     const targetFramework = item.$.targetFramework;
 
     if (!_.includes(targetFrameworksResult, targetFramework)) {

diff --git a/test/fixtures/dotnet-multiple-target-frameworks/packages.config b/test/fixtures/dotnet-multiple-target-frameworks/packages.config
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
   <package id="jQuery" version="3.1.1" targetFramework="net46" />
-  <package id="NLog" version="4.3.10" targetFramework="net46" />
+  <package id="NLog" version="4.3.10" />
   <package id="bootstrap" version="3.0.0" targetFramework="net451" />
 </packages>