feat: [OSM-529] updated errors to be error-catalog style #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dotkas
approved these changes
Jul 18, 2023
lib/index.ts
Outdated
Comment on lines
106
to
111
| throw new OpenSourceEcosystems.CannotGetFileFromSourceError( | ||
| 'No packages.config, project.json or project file found at ' + | ||
| `location: ${manifestFileFullPath}`, | ||
| ); |
There was a problem hiding this comment.
Can you add location to extras instead of in the details? It's easier to search for it in DataDog that way.
gemaxim
force-pushed
the
fix/port-to-error-catalog
branch
5 times, most recently
from
a3b7310 to
bba925d
Compare
dotkas
force-pushed
the
fix/port-to-error-catalog
branch
from
bba925d to
3116226
Compare
gemaxim
force-pushed
the
fix/port-to-error-catalog
branch
from
3116226 to
c365c70
Compare
|
🎉 This PR is included in version 5.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed error to be from error-catalog so that they are properly handlled for dotnet-deps.
What are the relevant tickets?
Jira ticket OSM-529
Additional questions
Should we also handle unexpected errors?