Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Calling CLI tools may be insecure #152

Closed
KOLANICH opened this issue Oct 16, 2018 · 4 comments
Closed

Calling CLI tools may be insecure #152

KOLANICH opened this issue Oct 16, 2018 · 4 comments
Milestone

Comments

@KOLANICH
Copy link
Contributor

Calling CLI tools and passing them arguments via CLI may be insecure. API should be used and it seems that ghostscript has one and python bindings too.

@KOLANICH KOLANICH changed the title Calljng CLI tools may be insecure Calling CLI tools may be insecure Oct 16, 2018
@vinayak-mehta
Copy link
Contributor

vinayak-mehta commented Oct 16, 2018

Thanks for reporting this @KOLANICH! #133 replaces the subprocess call with an API call. Though the ghostscript library for Python is available only on PyPI and not on any conda channels (correct me if I'm wrong). I'm thinking of either create a conda recipe and submitting to conda-forge or maybe vendorizing the library code. The best thing would be to replace ghostscript altogether #96. Would you like to take this up?

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Oct 16, 2018

The bindings are pure python (no compiled extension involved, ctypes are used) so I guess sdist is OK.

But we have a problem. The bindings have no docs, and we wanna avoid creating any files doing everything in memory. So the API currently used is unsuitable.

@vinayak-mehta
Copy link
Contributor

Let's continue the discussion at #133, closing this.

@vinayak-mehta
Copy link
Contributor

On second thought, let me reopen this till we have a solution for the ghostscript problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants