Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive for NoPrefixForInterfacesRuleTest #61

Closed
1 of 3 tasks
paul58914080 opened this issue Apr 17, 2022 · 2 comments
Closed
1 of 3 tasks

false positive for NoPrefixForInterfacesRuleTest #61

paul58914080 opened this issue Apr 17, 2022 · 2 comments

Comments

@paul58914080
Copy link
Collaborator

Summary

There seems to be an issue with the version 2.9.1 where even if we do not have a class prefixed with I still we get

ArchUnit Maven plugin reported architecture failures listed below :Rule Violated - com.societegenerale.commons.plugin.rules.NoPrefixForInterfacesRuleTest
[ERROR] java.lang.AssertionError: Rule 'classes that are interfaces should not be prefixed with I - this is a .Net convention.' failed to check any classes. This means either that no classes have been passed to the rule at all, or that no classes passed to the rule matched the `that()` clause. To allow rules being evaluated without checking any classes you can either use `ArchRule.allowEmptyShould(true)` on a single rule or set the configuration property `archRule.failOnEmptyShould = false` to change the behavior globally.

Type of Issue

It is a :

  • bug
  • request
  • question regarding the documentation

Current Behavior

Fails the build

Expected Behavior

Should build successfully

Steps to Reproduce (for bugs)

devs-from-matrix/hexagonal-spring-boot-java#231

Your Environment

  • Version used: 2.9.1
  • OS and version: Mac 11.5.1
@vincent-fuchs
Copy link
Collaborator

Thanks for raising this.. I really have no clue what happened, because the bug you report was there in 2.9.0, but was supposed to be fixed in 2.9.1 (see 5b9ef3a) .

I downloaded the 2.9.1 artifact and indeed, the fix is not supposed to be there.. maybe I screwed up the release process, since I am also in the process of moving to GitHub actions.

Anyway, I have now published a v2.9.2 which from what I can see on the Nexus repository, now contains the expected code.

It may not be available yet publicly, but it should, once the Maven central replication is complete.

Can you please try to upgrade once it's available, and let me know ?

Thanks

@paul58914080
Copy link
Collaborator Author

Thanks. It is fixed now. devs-from-matrix/hexagonal-spring-boot-java#233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants