Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate "expected loop to be an instance of Coolio::Loop" error #50

Closed
repeatedly opened this issue Dec 1, 2015 · 2 comments
Closed

Investigate "expected loop to be an instance of Coolio::Loop" error #50

repeatedly opened this issue Dec 1, 2015 · 2 comments

Comments

@repeatedly
Copy link
Contributor

From fluentd issue.

fluent/fluentd#703

Error log is here: https://github.com/shoichikaji/fluentd-error/blob/master/log/fluentd-only-error-coolio-1.4.2.log
@repeatedly
Copy link
Contributor Author

I think adding nil check fixes attach related error. This assumes passing nil to loop argument doesn't happen on normal situations.

https://github.com/tarcieri/cool.io/blob/5446a5e44f508ce1589a33e7ae61464530f857c2/ext/cool.io/watcher.h#L13

@repeatedly
Copy link
Contributor Author

For detach related error, we need to check when this error happens.

https://github.com/tarcieri/cool.io/blob/5446a5e44f508ce1589a33e7ae61464530f857c2/ext/cool.io/watcher.h#L31
or
https://github.com/tarcieri/cool.io/blob/5446a5e44f508ce1589a33e7ae61464530f857c2/ext/cool.io/watcher.h#L36

@saidie saidie mentioned this issue Nov 16, 2016
Merged
@ashie ashie mentioned this issue Dec 7, 2022
Merged
@ioquatix ioquatix closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@repeatedly @ioquatix