-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenging the Logic Behind "active" in Debounce Function #362
Comments
Hello @QTimort. I remember we discussed the possibility of creating a method to re-enable debounce, but at the time we couldn't find a clear reason why someone would disable and then re-enable debounce. The idea of opting out was the only approach we considered at the time. This lack of clear usage scenario is why we haven't implemented a method to reactivate. If you have any specific use cases in mind for this functionality, please share. Tag @rayepps in the conversation, and if he agrees, I'm willing to create a Pull Request adding this feature. |
Hello @MarlonPassos-git and @rayepps, I appreciate your prompt response to my initial query regarding the Current Limitation: Proposed Enhancement: Benefits:
I believe this enhancement would make the debounce function more versatile and user-friendly. I'm eager to hear your thoughts on this proposal and am willing to contribute to the discussion or development if needed. |
Hi @QTimort and @MarlonPassos-git, I appreciate the willingness to collaborate with careful thought and consideration you both exude. Let me invite both of you to join the effort over at radashi-org/radashi, a new actively maintained fork that's open to adding more maintainers (like you). ✌️ |
Hello, @MarlonPassos-git,
I'm struggling to grasp the rationale behind the active variable in the debounce function, which is puzzlingly set to false when cancelling a debounce. This approach effectively cripples the main purpose of the function, offering no clear reason or method for reactivation. The supposed aim of the cancel function is to clear a timer, not to render the whole debounce mechanism useless. This not only makes zero sense but also starkly contrasts with lodash's behavior even though I'm aware this isn't supposed to be a 1-1 lodash replica. Could you shed light on this interesting design of yours?
https://github.com/rayepps/radash/blame/03dd3152f560414e933cedcd3bda3c6db3e8306b/src/curry.ts#L131
The text was updated successfully, but these errors were encountered: