Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation: [@octokit/rest] "file" parameter is deprecated for ".repos.uploadReleaseAsset()". Use "data" instead #135

Closed
philpettican opened this issue Aug 5, 2021 · 3 comments

Comments

@philpettican
Copy link

`
Run softprops/action-gh-release@v1
with:
tag_name: 1.0.0
name: Release 1.0.0
target_commitish: XXX
token: ***
body: Changes in this Release

  • First Change

  • Second Change

    files: artifacts/test.zip

    draft: false
    prerelease: false
    👩‍🏭 Creating new GitHub release for tag 1.0.0 using commit "XXX"...
    ⬆️ Uploading test.zip...
    Deprecation: [@octokit/rest] "file" parameter is deprecated for ".repos.uploadReleaseAsset()". Use "data" instead
    at /home/runner/work/_actions/softprops/action-gh-release/v1/dist/index.js:1:437047
    at Array.forEach ()
    at Object.s [as uploadReleaseAsset] (/home/runner/work/_actions/softprops/action-gh-release/v1/dist/index.js:1:436958)
    at /home/runner/work/_actions/softprops/action-gh-release/v1/dist/index.js:1:52043
    at Generator.next ()
    at /home/runner/work/_actions/softprops/action-gh-release/v1/dist/index.js:1:50565
    at new Promise ()
    at i (/home/runner/work/_actions/softprops/action-gh-release/v1/dist/index.js:1:50313)
    at Object.t.upload (/home/runner/work/_actions/softprops/action-gh-release/v1/dist/index.js:1:51907)
    at /home/runner/work/_actions/softprops/action-gh-release/v1/dist/index.js:1:44485 {
    name: 'Deprecation'
    }`

@philpettican
Copy link
Author

This looks like it will be addressed once #134 is merged

@softprops
Copy link
Owner

It will. Still working on that one. Note this is only a deprecation warning and not an error so it should not affect your builds

@softprops
Copy link
Owner

this should now be fixed in the latest release. fixes were pushed to v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants