-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border radius to SearchAutocompleteInput markdown mentions #208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job 👍
I left one small comment that you can fix.
Other than that please change the Tests
step of the PR:
Run the web-based version of the application (web, electron, iOS or Android browser).
Open web app
Log in to an account.
Got to Reports or open Search router
Click or tab to focus the search box.
Type in from:, type:, currency:, status: or to:formulafollowed bythe corresponding datasome string
Accept auto-completion.
Verify that highlighted phrase has border radius
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @JakubKorytko you need to run npm pod install
to update podfile and commit updated podfile.
Co-authored-by: Mateusz Titz <[email protected]>
|
Moved here: Expensify#56866 |
Explanation of Change
Fixed Issues
$ Expensify#56560
PROPOSAL: N/A
Tests
from:
,type:
,currency:
,status:
orto:
followed by some string.Offline tests
N/A
QA Steps
Same as Tests section above.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Android.mov
iOS: Native
iOS: mWeb Safari
iOS.mov
MacOS: Chrome / Safari
Web.mov
MacOS: Desktop
Desktop.mov