Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isFormsStackingContext(node) does not have NativeState on react-native 0.73 #2887

Closed
mrousavy opened this issue May 1, 2024 · 3 comments
Closed
Labels
Missing repro Platform: iOS This issue is specific to iOS

Comments

@mrousavy
Copy link
Contributor

mrousavy commented May 1, 2024

Description

The param passed into isFormsStackingContext (a node) does not have a NativeState on react-native 0.73, maybe it's still a HostObject, but RNGH tries to unwrap it causing the app to crash.

Screenshot 2024-05-01 at 11 19 22

Steps to reproduce

  1. Create react-native 0.73 app
  2. Enable new arch
  3. Install rngh
  4. Run app

Snack or a link to a repository

I'll create a repro in a sec

Gesture Handler version

2.16.1

React Native version

0.73.7

Platforms

iOS

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Fabric (New Architecture)

Build type

Debug mode

Device

iOS simulator

Device model

iPhone 15 Pro

Acknowledgements

Yes

Copy link

github-actions bot commented May 1, 2024

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Platform: iOS This issue is specific to iOS label May 1, 2024
@j-piasecki
Copy link
Member

This change was made to support RN 0.74 (from HostObject to NativeState) and keeping backwards compatibility with changes like that is a pain. If you need to use RNGH on 0.73 with the new arch please use 2.15.0.

@mrousavy
Copy link
Contributor Author

mrousavy commented May 6, 2024

Cool, I'll upgrade to RN 0.74 then- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro Platform: iOS This issue is specific to iOS
Projects
None yet
Development

No branches or pull requests

2 participants