Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNGestureHandlerButton Stop Responding When Child View Contains Disabled Accessibility Gesture Recognizers #3376

Open
jcolicchio opened this issue Feb 4, 2025 · 1 comment · May be fixed by #3377
Assignees
Labels
Missing repro Platform: iOS This issue is specific to iOS

Comments

@jcolicchio
Copy link

Description

I noticed that some BorderlessButtons would stop responding to touches on iOS, and investigating, the cause seems to be that disbled accessibility gesture recognizers are being added to certain child views of RNGestureHandlerButton. This in turn causes the child view to return true from shouldHandleTouch, despite this view not having any tappable gesture recognizers.

It looks like a bandaid fix here might be to check for enabled gesture recognizers, rather than checking that the count is greater than zero, so that these strange, untappable, disabled gesture recognizers don't break the parent button's touch handling

Steps to reproduce

  1. Use BorderlessButton with a child view , which in turn has some child view
  2. Update the state of the app, generally just use it, this happens randomly
  3. Observe that some buttons become permanently unable to respond to taps
  4. With the debugger, observe that the affected RNGestureHandlerButton has a child view RCTViewComponentView which has two disabled accessibility gesture recognizers

Snack or a link to a repository

https://snack.expo.io/

Gesture Handler version

2.21.1

React Native version

0.76.0

Platforms

iOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

Copy link

github-actions bot commented Feb 4, 2025

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Platform: iOS This issue is specific to iOS label Feb 4, 2025
@m-bert m-bert self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro Platform: iOS This issue is specific to iOS
Projects
None yet
2 participants