-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*ependencies
bits in package.json
questionable
#37
Comments
*ependencies
bits in package.json
*ependencies
bits in package.json
questionable
3daa97f (on the dev branch) removes the |
Should we close these issues now that they are on the dev branch? Or wait until they make it to master? |
I was leaning in favor of the latter option -- waiting for the changes to make it to the release-related branch. |
I've created a label with text I've started using it to label an issue (perhaps also pr) if there is candidate code to address it on the dev branch. |
That is fine by me. It's getting difficult to keep track of them all, so that label will help. |
I agree it's getting difficult to track. Perhaps it's good to consider how much to put on dev at once. Not sure what a good criteria might be but the current amount might be too much -- perhaps another thing to keep in mind is the magical number 7 +/ 2. |
Looking at the draft CHANGELOG I wonder if that file could become a home for some outline or plans for future activities. |
I wonder if there's a good way for each of us to indicate to others that there are specific issues / prs we'd like review / feedback on. Initially I though possibly a I suppose there could be a tag per person...starting to sound too hacky perhaps. I guess this tends to become an issue when there are too many things and consequently the probability of something dropping through the cracks increases. |
For @pest-parser, we have a random "maintainer" chosen to do triage/reviewing of new PRs when they're made. |
Nice - though I guess this is more meaningful when there are more than a few participants :) |
The changes relevant to this issue can now be seen in 44ed28f. |
As mentioned above, addressed in 44ed28f. |
Currently,
*ependencies
bits inpackage.json
are like:tree-sitter-clojure/package.json
Lines 12 to 17 in 262d6d6
Based on recent investigations it has started to seem like these bits are unnecessary.
IIUC, what is relevant ATM is that the generated
.c
source use ABI 13.This is achievable with more recent versions of the tree-sitter cli by using the
generate
subcommand with the--abi
option and an appropriate number. Further, there is no need to usenpm
to obtain the tree-sitter cli as it can be compiled from source fairly easily (once you know how), there are also binaries downloadble from the tree-sitter repository releases page, and some distributions even have packages.My current leaning is toward removing
dependenices
anddevDependencies
and provide instructions regarding installation and usage of the tree-sitter cli that don't suggest that npm is necessary.Some of the advantages of doing this include:
I suspect this should help with ongoing maintenance as returning to pay attention after some period of inattention should become easier.
The text was updated successfully, but these errors were encountered: