[bug] vote account should be initialized to modern schema upon starting solana-test-validator in 1.16

[steveluscher]

Problem

I found the source of a pesky race condition in the web3.js tests. The tests assert the result of getProgramAccounts on accounts belonging to the vote program. One of those is the test validator's own vote account.

If the web3.js test's run soon enough after validator startup, the vote account will be the old 1.14 size (3731 bytes) instead of the new size (3762 bytes) and the test will fail. This is because the test validator creates a 1.14 vote account, and only upgrades it the first time that it has reason to update the vote state.

Proposed Solution

When starting a 1.16 test validator, create a modern vote account from the get-go.

[steveluscher]

Yep.

// In all cases, initializing with the 1_14_11 version of VoteState is safest, as this version will in-place upgrade

solana/programs/vote/src/vote_state/mod.rs

Line 1107 in eb262aa

let mut vote_account = AccountSharedData::new(lamports, VoteState1_14_11::size_of(), &id());

Can we change this? If not, can we change this just where the test validator is concerned?