Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Is it still necessary to include FeeCalculator in BlockHashQueue #34553

Closed
tao-stones opened this issue Dec 20, 2023 · 0 comments
Closed

Is it still necessary to include FeeCalculator in BlockHashQueue #34553

tao-stones opened this issue Dec 20, 2023 · 0 comments
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@tao-stones
Copy link
Contributor

Problem

When working on a separate issue, I noticed blockhash_queue.fee_calculator.lamports_per_signature was used, but perhaps shouldn't be?

Blockhash_queue includes FeeCalculator here.

But FeeCalculator seems pretty much be replaced by FeeStructure.

Proposed Solution

can FeeCalculator be removed to reduce confusion?
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Dec 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tao-stones