Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create “explicit intent” to import BIP-39 phrases or private key from wallet apps into Seed Vault #58

Open
lexer opened this issue Jul 20, 2022 · 1 comment
Milestone

Comments

@lexer
Copy link

lexer commented Jul 20, 2022

Proposal

Create “explicit intent” to import 1..N BIP-39 phrases or private key from wallet apps into Seed Vault

Sample use case

  1. Wallet app restores existing BIP-39 phrases or private keys from proprietary backup solution.
  2. Wallet app sends restored BIP-39 phrases and private keys to Sage Seed Vault using explicit intent.
  3. Saga shows warning UI about danger of importing existing secrets.

Considerations

  1. Considering that Sage will support import of BIP-39 phrases I don't think we are increasing risks here.
  2. We are reducing risks of customers manually copying BIP-39 seed phrases since copy buffer can be accessed by other apps on Android device.

Alternatives

Saga could offer to create a new BIP-39 seed phrase and transfer all known assets to it as part of the import. However this could lead to a loss of assets locked in DeFi protocols associated with imported secret.

References

Android Explicit Intents. https://developer.android.com/guide/components/intents-filters

@lexer lexer changed the title Create “explicit intent” to import BIP-39 phrases or private key from the app into Seed Vault Create “explicit intent” to import BIP-39 phrases or private key from wallet apps into Seed Vault Jul 20, 2022
@sdlaver sdlaver added this to the Backlog milestone Jul 21, 2022
@sdlaver
Copy link
Contributor

sdlaver commented Jul 21, 2022

Thanks @lexer. Adding to the backlog bucket, for consideration for the v1.1 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants