Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 replace sd-checkbox icon with sd-status-assets #1795

Open
3 of 9 tasks
karlbaumhauer opened this issue Jan 17, 2025 · 2 comments
Open
3 of 9 tasks

fix: 🤔 replace sd-checkbox icon with sd-status-assets #1795

karlbaumhauer opened this issue Jan 17, 2025 · 2 comments
Labels
🚧🛑🚧 BLOCKED 🚧🛑🚧 Item is blocked and cannot be continued. 🔧 code needs changes in code

Comments

@karlbaumhauer
Copy link
Contributor

karlbaumhauer commented Jan 17, 2025

Current behavior

As we did not have the sd-status-assets library implemented, we used an icon from "system" library in the sd-checkbox.

Image

Expected behavior

we are using our new sd-status-assets library implemented with #775

Steps to reproduce

See screenshot above

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@karlbaumhauer karlbaumhauer added the 🔧 code needs changes in code label Jan 17, 2025
@karlbaumhauer karlbaumhauer moved this to 🛠️ To be pre-refined in Solid Design System Project Board Jan 17, 2025
@karlbaumhauer karlbaumhauer added the 🚧🛑🚧 BLOCKED 🚧🛑🚧 Item is blocked and cannot be continued. label Jan 17, 2025
@karlbaumhauer
Copy link
Contributor Author

blocked by #775

@karlbaumhauer
Copy link
Contributor Author

@coraliefeil / @MartaPintoTeixeira could you pls check which other icons from the status-asset library are used in figma? I have the ffeling we need to extend this ticket with more components but just the checkmark in the sd-checkbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧🛑🚧 BLOCKED 🚧🛑🚧 Item is blocked and cannot be continued. 🔧 code needs changes in code
Projects
Status: 🛠️ To be pre-refined
Development

No branches or pull requests

1 participant