Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ replace valid icon on sd-input, sd-textarea, sd-combobox and sd-select #1809

Open
6 of 9 tasks
MartaPintoTeixeira opened this issue Jan 27, 2025 · 1 comment
Open
6 of 9 tasks
Assignees
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma

Comments

@MartaPintoTeixeira
Copy link
Contributor

MartaPintoTeixeira commented Jan 27, 2025

User Story

As a designer of the Solid Design System, I would like to replace the existing check icon (used to represent the valid state) with a new check icon that better matches the style of the invalid icon by ensuring it uses a more similar amount of white space and line weight, resulting in a more pleasant experience for the user, so that we improve the design system's visual harmony and maintain optical consistency across icons.

Suggested Solution

replace valid icon on sd-input, sd-textarea, sd-combobox and sd-select.

Image

Subtasks

DoR

  • Item has business value
  • Item all subtasks have been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • All subtasks have been closed
@coraliefeil
Copy link
Contributor

This is such a small task ... I think we don’t need an epic for that @yoezlem or?

@yoezlem yoezlem moved this from 📋 Backlog to 🛠️ To be pre-refined in Solid Design System Project Board Jan 30, 2025
@yoezlem yoezlem added 🎨 figma needs changes in Figma 🔧 code needs changes in code and removed 🙌 Epic labels Jan 30, 2025
@MartaPintoTeixeira MartaPintoTeixeira changed the title feat: ✨ replace valid icon on sd-input, sd-textarea and sd-select feat: ✨ replace valid icon on sd-input, sd-textarea, sd-combobox and sd-select Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma
Projects
Status: 🛠️ To be pre-refined
Development

No branches or pull requests

3 participants