Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom persist and hydrate callbacks for primitive types. #24

Open
solid-yuriiprykhodko opened this issue Aug 9, 2021 · 0 comments
Open

Support custom persist and hydrate callbacks for primitive types. #24

solid-yuriiprykhodko opened this issue Aug 9, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@solid-yuriiprykhodko
Copy link
Collaborator

As pointed out by @solid-vovabeloded:
Currently if we use HydratedSubject with a primitive type, custom persist and hydrate callbacks won't be invoked, or used at all:
image

The idea is to change the check order in the above method to use the custom callbacks, if they were provided, and then fall back to standard handling.
@solid-yuriiprykhodko solid-yuriiprykhodko added the enhancement New feature or request label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solid-yuriiprykhodko