feat: Set Vary header.

CommunitySolidServer · Jan 21, 2021 · 693d48b · 693d48b
1 parent b487dc7
commit 693d48b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/config/presets/middleware.json b/config/presets/middleware.json
@@ -25,6 +25,10 @@
         {
           "@type": "HeaderHandler",
           "HeaderHandler:_headers": [
+            {
+              "HeaderHandler:_headers_key": "Vary",
+              "HeaderHandler:_headers_value": "Accept,Authorization,Origin"
+            },
             {
               "HeaderHandler:_headers_key": "X-Powered-By",
               "HeaderHandler:_headers_value": "Community Solid Server"

diff --git a/test/integration/Middleware.test.ts b/test/integration/Middleware.test.ts
@@ -34,6 +34,27 @@ describe('An Express server with middleware', (): void => {
     server.close();
   });
 
+  it('sets a Vary header containing Accept.', async(): Promise<void> => {
+    const res = await request(server).get('/');
+    expect(res.header).toEqual(expect.objectContaining({
+      vary: expect.stringMatching(/(^|,)\s*Accept\s*(,|$)/iu),
+    }));
+  });
+
+  it('sets a Vary header containing Authorization.', async(): Promise<void> => {
+    const res = await request(server).get('/');
+    expect(res.header).toEqual(expect.objectContaining({
+      vary: expect.stringMatching(/(^|,)\s*Authorization\s*(,|$)/iu),
+    }));
+  });
+
+  it('sets a Vary header containing Origin.', async(): Promise<void> => {
+    const res = await request(server).get('/');
+    expect(res.header).toEqual(expect.objectContaining({
+      vary: expect.stringMatching(/(^|,)\s*Origin\s*(,|$)/iu),
+    }));
+  });
+
   it('sends server identification in the X-Powered-By header.', async(): Promise<void> => {
     const res = await request(server).get('/');
     expect(res.header).toEqual(expect.objectContaining({