Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder .acl permissions are not inherited #1279

Closed
jaxoncreed opened this issue Jul 30, 2019 · 6 comments
Closed

Folder .acl permissions are not inherited #1279

jaxoncreed opened this issue Jul 30, 2019 · 6 comments

Comments

@jaxoncreed
Copy link
Contributor

This only seems to be happening on https://inrupt.net

Cannot access profile photos

Users cannot access notifications on their own pods

@michielbdejong
Copy link
Member

They should never be inherited. photos inside /profile/ will only be affected by https://github.com/solid/node-solid-server/blob/master/default-templates/new-account/profile/.acl (where defaultForNew is the old name for default), and since that /profile/.acl exists, it will never inherit any rules from /.acl.

If you remove /profile/.acl then /.acl will apply instead.

@james-martin-jd
Copy link

I've been seeing this bug in the SDK. Several pods, which used to serve up items in /profile/, now are showing 403 errors. I checked my own pod (https://jmartin.inrupt.net/profile/James-profile_1564148145000_.jpeg) and sure enough /profile/.acl doesn't exist anymore. I'm not sure why it's not there. When I try to use the data browser "set folder permissions" button, it threw errors in the console. I unfortunately don't have the error message handy.

The reason for that is I refreshed and intended to try again, but after a refresh, the /profile/.acl file was there now, and I can set permissions on that folder once more. I'm not sure how I (and other pods, seemingly) got into a strange corrupted state. It appears that the root cause is my /profile/.acl file disappeared one day.

@brownhoward
Copy link

brownhoward commented Aug 2, 2019

Also seeing the same issues with newly created Pods on https://solid.community.

One thing to note is if you add the WebID as Owner under "Access to things within this folder:" in sharing for /public folder, they can then access the Global Inbox and hence get the global notifications.

@megoth
Copy link
Contributor

megoth commented Aug 5, 2019

Just wanted to chime in that based on the current version of NSS, there should be created a .acl file in all folders, as witnessed in https://github.com/solid/node-solid-server/tree/master/default-templates/new-account .

@kevin-howard-jd the problem you describe sounds really serious! A WebID getting access to /inbox based on them having permission granted to /public? That's really, really bad, if that's the case.

@michielbdejong
Copy link
Member

Was this resolved now with the latest dev.inrupt.net test round?

@jaxoncreed
Copy link
Contributor Author

It was

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants