Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the content of the subheader into a footer #150

Closed
megoth opened this issue Aug 12, 2019 · 3 comments
Closed

Move the content of the subheader into a footer #150

megoth opened this issue Aug 12, 2019 · 3 comments
Assignees
@megoth
Milestone
Data Browser Rele...

Comments

@megoth
Copy link
Contributor

megoth commented Aug 12, 2019

The grey line that shows the owner of the current Pod (that is shown when you're visiting another Pod) can be a bit obtrusive. We suggest that we move it into a footer.

Additionally, we suggest to make this footer "sticky", as described at https://css-tricks.com/couple-takes-sticky-footer/ .
@megoth
Copy link
Contributor Author

megoth commented Aug 12, 2019

Tim also suggest us adding a link to https://solidproject.org/ and to link to the root of the Pod in the text "the Pod".

@megoth megoth self-assigned this Aug 14, 2019
@megoth
Copy link
Contributor Author

megoth commented Aug 14, 2019

I propose to make the footer as simple as possible, as shown in the example below:

AwesomeScreenshot-megoth-localhost--2019-08-14_6_47

megoth added a commit to SolidOS/mashlib that referenced this issue Aug 14, 2019
@megoth
Introducing footer, moving content of subheader there
fa9eaaf 
Also making the footer sticky using flex, as shown on https://css-tricks.com/couple-takes-sticky-footer/#article-header-id-3

This should solve SolidOS/solid-panes#150
@megoth megoth mentioned this issue Aug 14, 2019
Merged
@megoth
Copy link
Contributor Author

megoth commented Aug 28, 2019

This was done in SolidOS/mashlib#49

@megoth megoth closed this as completed Aug 28, 2019
@brownhoward brownhoward added this to the Data Browser Release 1 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@megoth megoth

Labels
None yet
Projects
None yet
Milestone
Data Browser Release 1
Development

No branches or pull requests
2 participants
@megoth @brownhoward