Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu does not show Profile image #169

Open
brownhoward opened this issue Sep 4, 2019 · 2 comments · Fixed by SolidOS/solid-ui#119
Open

Menu does not show Profile image #169

brownhoward opened this issue Sep 4, 2019 · 2 comments · Fixed by SolidOS/solid-ui#119
Assignees
@megoth
Labels
bug
Milestone
Data Browser Rele...

Comments

@brownhoward
Copy link

The Data Browser dropdown menu in the top-right corner displays the default image, not my Profile image.

To Replicate

  1. Create a new Pod.
  2. Add a new Profile image.

Expected Behaviour

  1. Profile image is displayed in the top-right corner of the Data Browser.

Actual Behaviour

  1. The dropdown menu still displayed the default icon.
    Note: This behaviour stays the same even if you refresh the page and/or logout/login.
@brownhoward brownhoward added the bug label Sep 6, 2019
@megoth
Copy link
Contributor

megoth commented Sep 16, 2019 •
edited
Loading

Use the existing functionality in solid-ui for fetching profile images (UI.widgets.setImage).

@megoth megoth self-assigned this Sep 16, 2019
megoth added a commit to SolidOS/solid-ui that referenced this issue Sep 16, 2019
@megoth
Extracted findProfileImage from findImage in setImage
13ba814 
findImage used to be a private function in UI.widgets.buttons.setImage, but the logic can be reused other places, so I've tried to extract the logic so that it becomes a method exposed as UI.authn.findProfileImage.

Partially fixes SolidOS/solid-panes#169
@megoth megoth mentioned this issue Sep 16, 2019
Merged
megoth added a commit to SolidOS/mashlib that referenced this issue Sep 16, 2019
@megoth
Making use of UI.authn.findProfileImage
dd85431 
Do not merge this until https://github.com/solid/solid-ui/pull/119 is merged and pushed in a new release.

This adds solid-ui as a dependency for mashlib.

Partial fix for SolidOS/solid-panes#169
@megoth megoth mentioned this issue Sep 16, 2019
Merged
@brownhoward brownhoward added this to the Data Browser Release 3 milestone Oct 28, 2019
@brownhoward
Copy link
Author

@megoth Profile image is, once again, not displayed.

@brownhoward brownhoward reopened this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@megoth megoth

Labels
bug
Projects
None yet
Milestone
Data Browser Release 5
Development

Successfully merging a pull request may close this issue.

Extracted findProfileImage from findImage in setImage SolidOS/solid-ui
2 participants
@megoth @brownhoward