Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can edit Trusted App URL but does not save #170

Closed
brownhoward opened this issue Sep 4, 2019 · 0 comments
Closed

Can edit Trusted App URL but does not save #170

brownhoward opened this issue Sep 4, 2019 · 0 comments
Assignees
@megoth
Labels
bug
Milestone
Data Browser Rele...

Comments

@brownhoward
Copy link

brownhoward commented Sep 4, 2019 •
edited
Loading

When viewing the list of Trusted Apps in the Data Browser, I am allowed to edit the Trusted App URLs. However, when I click 'Update', the edited URL is not saved. Rather a new Trusted App record is created.

Either:

  1. The edited URL should be saved correctly; or,
  2. The URL should be made read-only.

I suggest we go with 2. as it is easy enough to delete and add a Trusted App, and we would need to somehow confirm the URL is correct.
@brownhoward brownhoward added the bug label Sep 6, 2019
@megoth megoth self-assigned this Sep 18, 2019
megoth added a commit that referenced this issue Sep 18, 2019
@megoth
Updates same row when entering new domain for trusted app
ebc0bcb 
Fix for #170

Also contains some clean-up of syntax (scout rule)
@megoth megoth mentioned this issue Sep 18, 2019
Merged
@brownhoward brownhoward added this to the Data Browser Release 4 milestone Oct 28, 2019
@megoth megoth closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@megoth megoth

Labels
bug
Projects
None yet
Milestone
Data Browser Release 4
Development

No branches or pull requests
2 participants
@megoth @brownhoward