Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A basic preferences global Pane that allows the user to indicate whether they're a Power User and/or a Developer #157

Merged
merged 11 commits into from
Aug 26, 2019

Conversation

Vinnl
Copy link
Contributor

@Vinnl Vinnl commented Aug 22, 2019

This adds the code by Tim that uses the Classifier to set Power User or Developer mode.

Fixes #144, fixes #145.

@Vinnl Vinnl requested review from megoth and timbl August 22, 2019 16:35
Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from one small change

dashboard/preferenceForm.ttl Outdated Show resolved Hide resolved
Copy link
Contributor

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and smaller things to fix - looks good ^_^

dashboard/basicPreferences.source.ts Outdated Show resolved Hide resolved
dashboard/basicPreferences.source.ts Show resolved Hide resolved
dashboard/basicPreferences.source.ts Outdated Show resolved Hide resolved
dashboard/ontology-extra.ttl Outdated Show resolved Hide resolved
@Vinnl
Copy link
Contributor Author

Vinnl commented Aug 26, 2019

Thanks Arne, I've incorporated your suggestions.

@Vinnl Vinnl requested a review from megoth August 26, 2019 07:28
Copy link
Contributor

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^_^

@megoth
Copy link
Contributor

megoth commented Aug 26, 2019

@Vinnl Could you fix the conflicting file, then merge? You've fixed Tim's feedback, so I reckon it looks good for him as well ^_^

@Vinnl Vinnl force-pushed the 144-basicPreferences branch from d2a2ff2 to 4a51407 Compare August 26, 2019 13:29
@Vinnl Vinnl merged commit f403516 into master Aug 26, 2019
@Vinnl Vinnl deleted the 144-basicPreferences branch August 26, 2019 13:30
@megoth megoth added the release-minor Add to PR to indicate that merging it denotes a minor (semver) release label Aug 29, 2019
@brownhoward brownhoward added this to the Data Browser Release 2 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Add to PR to indicate that merging it denotes a minor (semver) release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add developer and power user mode Reintroduce basicPreferences
4 participants