Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account deletion link(s) to preferences #163

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Conversation

Vinnl
Copy link
Contributor

@Vinnl Vinnl commented Aug 27, 2019

Note that this method assumes that the server is running Node Solid
Server, or at least provides the deletion link at
/account/delete.

It makes HEAD requests to what would be the deletion pages in single-user and multi-user Node Solid Server setups, respectively, as suggested at #146 (comment).

Fixes #146.

@Vinnl Vinnl requested a review from megoth August 27, 2019 10:37
@Vinnl Vinnl force-pushed the 146-delete-profile branch from d29fbc6 to 556c129 Compare August 27, 2019 10:37
Copy link
Contributor

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dashboard/basicPreferences.source.ts Show resolved Hide resolved
@megoth
Copy link
Contributor

megoth commented Aug 27, 2019

Please fix conflicting files, then merge.

Note that this method assumes that the server is running Node Solid
Server, or at least provides the deletion link at
`/account/delete`.
@Vinnl Vinnl force-pushed the 146-delete-profile branch from ff357ff to 210f735 Compare August 28, 2019 07:25
@Vinnl Vinnl merged commit 346f0df into master Aug 28, 2019
@megoth megoth added the release-minor Add to PR to indicate that merging it denotes a minor (semver) release label Aug 29, 2019
@brownhoward brownhoward added this to the Data Browser Release 2 milestone Oct 28, 2019
@timea-solid timea-solid deleted the 146-delete-profile branch February 28, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Add to PR to indicate that merging it denotes a minor (semver) release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to delete user profile from basicPreferences
3 participants