Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract TTL for basicPreferences into own files #164

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Extract TTL for basicPreferences into own files #164

merged 1 commit into from
Aug 27, 2019

Conversation

Vinnl
Copy link
Contributor

@Vinnl Vinnl commented Aug 27, 2019 •
edited
Loading

This builds on #155, applying it to basicPreferences.

@Vinnl Vinnl requested a review from megoth August 27, 2019 10:54
megoth
megoth approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - makes code easier to read

@megoth megoth merged commit 4002dc3 into master Aug 27, 2019
@megoth megoth deleted the extract-ttls branch August 27, 2019 17:09
@megoth megoth added the release-patch Add to PR to indicate that merging it denotes a patch (semver) release label Aug 29, 2019
@brownhoward brownhoward added this to the Data Browser Release 2 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megoth megoth megoth approved these changes

Assignees
No one assigned
Labels
release-patch Add to PR to indicate that merging it denotes a patch (semver) release
Projects
None yet
Milestone
Data Browser Release 2
Development

Successfully merging this pull request may close these issues.
3 participants
@Vinnl @megoth @brownhoward