Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Client's IP Address #641

Closed
ryansolid opened this issue Jan 13, 2023 · 1 comment
Closed

Get Client's IP Address #641

ryansolid opened this issue Jan 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ryansolid
Copy link
Member

We need this feature for more than a few reasons but it isn't part of the Request model. I think we should just jam it on Server Context probably as clientAddress. Luckily others have gone through this: withastro/astro#3708

So we should add this.
@ryansolid ryansolid added the enhancement New feature or request label Jan 13, 2023
@indeyets
Copy link
Contributor

@ryansolid this commit breaks types. see https://github.com/solidjs/solid-start/actions/runs/3917523573/jobs/6697359050

previous commit was green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indeyets @ryansolid