Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin users have the option to edit payment amount #29

Closed
seand7565 opened this issue Jun 10, 2020 · 1 comment · Fixed by #56
Closed

Admin users have the option to edit payment amount #29

seand7565 opened this issue Jun 10, 2020 · 1 comment · Fixed by #56
Labels
solidus admin Touches the Solidus backend/admin

Comments

@seand7565
Copy link
Contributor

On an uncaptured payment, admin users can change the amount that the customer is being charged on the Payment object. However, this does not affect the amount that PayPal actually charges.
@seand7565 seand7565 added the solidus admin Touches the Solidus backend/admin label Jun 10, 2020
@elia
Copy link
Member

elia commented Jul 8, 2020

📝 note: Look into the possibility of using some kind of "vault" to store payment info (to be reused) with PCP

seand7565 added a commit to seand7565/solidus_paypal_commerce_platform that referenced this issue Jul 9, 2020
@seand7565
Send amount of payment to PayPal on capture
cca14c5 
Previously, we were just telling PayPal to capture the amount that
was authorized. However, admin users have the ability to edit the
amount of the payment, so now we're sending the amount of the payment
to PayPal for capturing.

You can capture less than the authorized amount just fine, however
trying to capture MORE than that amount will fail the payment and
flash a "Something went wrong" error. I think that's fine for the
functionality we want - I would expect to not be able to charge
more than the customer authorized.

Should fix solidusio#29
@seand7565 seand7565 mentioned this issue Jul 9, 2020
Merged
seand7565 added a commit to seand7565/solidus_paypal_commerce_platform that referenced this issue Jul 9, 2020
@seand7565
Send amount of payment to PayPal on capture
d9d917f 
Previously, we were just telling PayPal to capture the amount that
was authorized. However, admin users have the ability to edit the
amount of the payment, so now we're sending the amount of the payment
to PayPal for capturing.

You can capture less than the authorized amount just fine, however
trying to capture MORE than that amount will fail the payment and
flash a "Something went wrong" error. I think that's fine for the
functionality we want - I would expect to not be able to charge
more than the customer authorized.

Should fix solidusio#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
solidus admin Touches the Solidus backend/admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send amount of payment to PayPal on capture seand7565/solidus_paypal_commerce_platform
2 participants
@elia @seand7565