Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a URL generator for the PayPal JS SDK #8

Closed
elia opened this issue May 21, 2020 · 1 comment
Closed

Add a URL generator for the PayPal JS SDK #8

elia opened this issue May 21, 2020 · 1 comment
Assignees
Labels
paypal checkout Related to PayPal Checkout Buttons solidus frontend Touches the Solidus frontend/storefront

Comments

@elia
Copy link
Member

elia commented May 21, 2020

Doc: https://developer.paypal.com/docs/checkout/reference/customize-sdk/?mark=javascript%20sdk#query-parameters

This can be either a helper or a class method (the latter makes sense because it's not dependent on anything), something along the lines of:

def paypal_javascript_sdk_url(client_id: , )
@elia elia added solidus frontend Touches the Solidus frontend/storefront paypal checkout Related to PayPal Checkout Buttons labels May 21, 2020
@seand7565
Copy link
Contributor

Without realizing it, I think I already did this in my open PR - I used a method in the gateway called sdk_url, does that work for you? #10

@seand7565 seand7565 self-assigned this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paypal checkout Related to PayPal Checkout Buttons solidus frontend Touches the Solidus frontend/storefront
Projects
None yet
Development

No branches or pull requests

2 participants