Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README lists two different types of PayPal credentials #97

Closed
seand7565 opened this issue Oct 6, 2020 · 0 comments
Closed

README lists two different types of PayPal credentials #97

seand7565 opened this issue Oct 6, 2020 · 0 comments

Comments

@seand7565
Copy link
Contributor

The README has the following credentials being set:
PAYPAL_PARTNER_ID
PAYPAL_PARTNER_CLIENT_ID
PAYPAL_CLIENT_ID
PAYPAL_CLIENT_SECRET

Under normal circumstances, these are the ones that should be being set:
PAYPAL_CLIENT_ID
PAYPAL_CLIENT_SECRET
We probably don't want people overriding the partner_id information unless they're doing something super crazy, like building a marketplace. I think to avoid confusion (and people not using the default partner information), we should remove the references to the partner_id and partner_client_id from the README, or at the very least explain why they are there and that you probably should avoid setting them.

seand7565 added a commit to seand7565/solidus_paypal_commerce_platform that referenced this issue Oct 6, 2020
You wouldn't normally change these, and they only matter in the
context of the wizard - they're not used elsewhere. Unless you're
building a marketplace, I don't think there's any reason to adjust
these. In addition, we already list PAYPAL_CLIENT information which
conflicts with this a bit, so I think to clear up the confusion
we should just remove this section from the README. Ref: solidusio#97
seand7565 added a commit to seand7565/solidus_paypal_commerce_platform that referenced this issue Oct 6, 2020
You wouldn't normally change these, and they only matter in the
context of the wizard - they're not used elsewhere. Unless you're
building a marketplace, I don't think there's any reason to adjust
these. In addition, we already list PAYPAL_CLIENT information which
conflicts with this a bit, so I think to clear up the confusion
we should just remove this section from the README. Ref: solidusio#97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant