Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency to PayPal SDK URL #108

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

seand7565
Copy link
Contributor

Adds a currency to the PayPal SDK URL, which is necessary when the
currency is not USD. Otherwise, PayPal will throw an error and checkout
will be aborted.

Also makes our order creation process respect the current pricing
options.

closes #107

Adds a currency to the PayPal SDK URL, which is necessary when the
currency is not USD. Otherwise, PayPal will throw an error and checkout
will be aborted.

Also makes our order creation process respect the current pricing
options.
@seand7565 seand7565 merged commit 136e1c5 into solidusio:master Oct 26, 2020
@bobomimi
Copy link

bobomimi commented Oct 27, 2020

Hi
Thank you very much for the quick response and action but it still not working for me and I'm getting the same error when I changing the default currency in spree.rb .

best regards

terminal:
CACHE Spree::State Load (0.0ms) SELECT "spree_states".* FROM "spree_states" WHERE "spree_states"."id" = $1 LIMIT $2 [["id", 3441], ["LIMIT", 1]]
CACHE Spree::Country Load (0.0ms) SELECT "spree_countries".* FROM "spree_countries" WHERE "spree_countries"."id" = $1 LIMIT $2 [["id", 233], ["LIMIT", 1]]
Completed 201 Created in 1580ms (Views: 0.8ms | ActiveRecord: 4.6ms | Allocations: 30342)

@seand7565
Copy link
Contributor Author

@bobomimi Are you using the the latest version of solidus_paypal_commerce_platform sourced from Github? I haven't released a minor version yet, so the rubygems version of this extension is still out of date.

@bobomimi
Copy link

bobomimi commented Oct 28, 2020

my bad, working perfectly fine when the source is Github.
thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There was a problem connecting with paypal.
3 participants