Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new factories loading method #118

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

kennyadsl
Copy link
Member

No description provided.

@kennyadsl kennyadsl requested a review from seand7565 February 19, 2021 18:12
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #118 (1c71f70) into master (7a70553) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files          30       30           
  Lines         466      466           
=======================================
  Hits          418      418           
  Misses         48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a70553...1c71f70. Read the comment docs.

Copy link
Contributor

@seand7565 seand7565 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Missed this notification in the sea of other notifications, but looks good!

@kennyadsl kennyadsl merged commit 394dae6 into master Mar 12, 2021
@kennyadsl kennyadsl deleted the kennyadsl/use-new-factories-loading branch March 12, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants