-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PayPal button to product page #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seand7565
force-pushed
the
add_product_button
branch
3 times, most recently
from
June 25, 2020 14:54
7cdd047
to
b4bc8d9
Compare
seand7565
force-pushed
the
add_product_button
branch
from
June 29, 2020 20:15
b4bc8d9
to
654bf20
Compare
seand7565
force-pushed
the
add_product_button
branch
2 times, most recently
from
June 30, 2020 19:53
4c195b1
to
dd92dde
Compare
seand7565
force-pushed
the
add_product_button
branch
6 times, most recently
from
July 6, 2020 20:34
5ca2b12
to
64669aa
Compare
elia
requested changes
Jul 7, 2020
app/controllers/solidus_paypal_commerce_platform/orders_controller.rb
Outdated
Show resolved
Hide resolved
app/assets/javascripts/spree/frontend/solidus_paypal_commerce_platform/button_actions.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/spree/frontend/solidus_paypal_commerce_platform/button_actions.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/spree/frontend/solidus_paypal_commerce_platform/button_actions.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/spree/frontend/solidus_paypal_commerce_platform/button_actions.js
Outdated
Show resolved
Hide resolved
seand7565
force-pushed
the
add_product_button
branch
from
July 7, 2020 20:09
64669aa
to
7db0494
Compare
seand7565
force-pushed
the
add_product_button
branch
2 times, most recently
from
July 9, 2020 14:11
0277fa0
to
662464e
Compare
elia
reviewed
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more questions, and possibly a pending change related to #45 (comment)
app/controllers/solidus_paypal_commerce_platform/orders_controller.rb
Outdated
Show resolved
Hide resolved
The create action doesn't _actually_ create anything, it simply formats the order to something usable by PayPal, sends it off to them, and returns the response. It's really more of a show action, so I'm renaming it as such. And since it shows the `paypal_order` object, I'm moving it to a paypal_orders controller. ..Plus, I need to use the create action for the next commit. 😅
Adds an API endpoint to control order creation from the product PayPal button. The users existing order - if any - is replaced with this new order. This order should contain only the chosen quantity of the selected variant on that product page. It also associates the current user with the order, if it can find them.
Adds the ability to use the PayPal button on the product page, create a new order, and check out with only the selected product. Note that variant_id, quantity, and user_id will all have to be populated in the SPCP namespace when the button is loaded in.
Adds a preference to toggle the product page, and a partial name to use for the product page paypal button view.
Adds deface override which adds in a payment buttons partial - this partial can handle multiple payment buttons, so if other payment methods want to add their own instant checkout buttons, it's possible. It can also handle multiple SPCP buttons, if for some reason the store wants multiple.
seand7565
force-pushed
the
add_product_button
branch
from
July 9, 2020 18:11
662464e
to
ad1ce24
Compare
elia
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
#43 and #42merged 😬create
action toshow
to be more inline with what it doesFixes #27