Add configuration options to SolidusPaypalCommercePlatform #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seand7565
added
the
chore
elia
requested changes
Jul 2, 2020
There was a problem hiding this comment.
Looks great overall!
One nit is that in other extension the config class is named Configuration and might make sense to stay consistent. About the commits I would suggest keeping the whole rename into the first one, and the order-simulator addition in the second, that should make for a really clean "blame" for our future selves 🕵️
seand7565
force-pushed
the
add_config
branch
3 times, most recently
from
6a4c962 to
8ab0587
Compare
elia
requested changes
Jul 9, 2020
spec/lib/solidus_paypal_commerce_platform/configuration_spec.rb
Outdated
Show resolved
Hide resolved
Renames Environment to Config so that we can set up extension configuration. Now instead of just `SolidusPaypalCommercePlatform.env` you reference the config object first like `SolidusPaypalCommercePlatform.config.env` - this PR updates existing code to conform to this new standard.
Adds ability to configure the configuration setup, and adds an order_simulator_class so that the order_simulator class is configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to configure SPCP with:
instead of just setting options directly onto SolidusPaypalCommercePlatform. Also makes order_simulator a customizable class to solve #36