Verify amount to charge with order total #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be able to verify that the amount we receive from PayPal equals the outstanding balance of the order. So, this API endpoint allows us to check the paypal_balance with the orders outstanding_total.
Adds a function that hits the amount verification API endpoint, so that we can be sure that the amount PayPal sends us is the correct amount to charge the user. Also moves the advanceOrder function to before the addPayment function, since we need the shipment_total to be updated and that only happens on the shipment order state.
seand7565
force-pushed
the
add_amount_check
branch
from
ded6bbe to
91faf20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to verify that the amount we receive from PayPal
equals the outstanding balance of the order. So, this adds an API
endpoint that allows us to verify that, and sends the amount PayPal
says is due there for verification.
Also fixes an issue with the cart checkout - moving the advanceOrder
function to a more sensible location.
ref: #37